Do not move field annotations around arrays#712
Merged
Conversation
knutwannheden
approved these changes
Aug 16, 2025
mergify bot
added a commit
to robfrank/linklift
that referenced
this pull request
Sep 2, 2025
… 2.15.0 to 2.16.0 [skip ci] Bumps [org.openrewrite.recipe:rewrite-static-analysis](https://github.com/openrewrite/rewrite-static-analysis) from 2.15.0 to 2.16.0. Release notes *Sourced from [org.openrewrite.recipe:rewrite-static-analysis's releases](https://github.com/openrewrite/rewrite-static-analysis/releases).* > 2.16.0 > ------ > > What's Changed > -------------- > > * fix: Enhanced UseCollectionInterfaces to prevent conversions when non interface methods are used by [`@e5LA`](https://github.com/e5LA) in [openrewrite/rewrite-static-analysis#709](https://github.com/openrewrite/rewrite-static-analysis/pull/709) > * Improve support method invocations for `RemoveRedundantTypeCast` by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-static-analysis#711](https://github.com/openrewrite/rewrite-static-analysis/pull/711) > * Do not move field annotations around arrays by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#712](https://github.com/openrewrite/rewrite-static-analysis/pull/712) > * Use classpath from resource for Refaster by [`@jevanlingen`](https://github.com/jevanlingen) in [openrewrite/rewrite-static-analysis#714](https://github.com/openrewrite/rewrite-static-analysis/pull/714) > * Fix NPE in UseCollectionInterfaces with annotated raw collection types by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#717](https://github.com/openrewrite/rewrite-static-analysis/pull/717) > * Prefer `System getProperty()` over `getenv()` by [`@Akanksha928`](https://github.com/Akanksha928) in [openrewrite/rewrite-static-analysis#679](https://github.com/openrewrite/rewrite-static-analysis/pull/679) > * Expand coverage of UseCollectionInterfaces to LinkedList, Stack, TreeMap, TreeSet and PriorityQueue by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#718](https://github.com/openrewrite/rewrite-static-analysis/pull/718) > * Fix ReplaceLambdaWithMethodReference to not replace lambdas inside anonymous inner classes by [`@timtebeek`](https://github.com/timtebeek) in [openrewrite/rewrite-static-analysis#723](https://github.com/openrewrite/rewrite-static-analysis/pull/723) > > New Contributors > ---------------- > > * [`@Akanksha928`](https://github.com/Akanksha928) made their first contribution in [openrewrite/rewrite-static-analysis#679](https://github.com/openrewrite/rewrite-static-analysis/pull/679) > > **Full Changelog**: <openrewrite/rewrite-static-analysis@v2.15.0...v2.16.0> Commits * [`53c6b3e`](openrewrite/rewrite-static-analysis@53c6b3e) Update documentation examples * [`0437c5c`](openrewrite/rewrite-static-analysis@0437c5c) Fix ReplaceLambdaWithMethodReference to not replace lambdas inside anonymous ... * [`da75646`](openrewrite/rewrite-static-analysis@da75646) Expand coverage of UseCollectionInterfaces to LinkedList, Stack, TreeMap, Tre... * [`d01363c`](openrewrite/rewrite-static-analysis@d01363c) Prefer `System getProperty()` over `getenv()` ([#679](https://github.com/openrewrite/rewrite-static-analysis/issues/679)) * [`6f8b0df`](openrewrite/rewrite-static-analysis@6f8b0df) AssertJ best practices * [`5f64939`](openrewrite/rewrite-static-analysis@5f64939) Fix NPE in UseCollectionInterfaces with annotated raw collection types ([#717](https://github.com/openrewrite/rewrite-static-analysis/issues/717)) * [`feee568`](openrewrite/rewrite-static-analysis@feee568) Fix annotation order and import * [`a51a3ba`](openrewrite/rewrite-static-analysis@a51a3ba) Use classpath from resource for Refaster ([#714](https://github.com/openrewrite/rewrite-static-analysis/issues/714)) * [`fa1d3c3`](openrewrite/rewrite-static-analysis@fa1d3c3) Fix OnlyCatchDeclaredExceptions to skip generic type variables * [`21ad269`](openrewrite/rewrite-static-analysis@21ad269) Do not move field annotations around arrays ([#712](https://github.com/openrewrite/rewrite-static-analysis/issues/712)) * Additional commits viewable in [compare view](openrewrite/rewrite-static-analysis@v2.15.0...v2.16.0) [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per: https://jspecify.dev/docs/user-guide/#type-use-annotation-syntax
I'd briefly considered making this optional, but we don't tend to like having options on recipes.
There's a slight risk here with some of the nullable annotations where we might change semantics if we don't make these changes I believe, but I don't see that called out on: https://www.moderne.ai/blog/mass-migration-of-nullability-annotations-to-jspecify